refactor(coin-evm): remove some dead code by francois-guerin-ledger · Pull Request #14854 · LedgerHQ/ledger-live

francois-guerin-ledger · 2026-02-26T15:59:31Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- coin evm

📝 Description

Remove some dead code on coin evm

❓ Context

JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/LIVE-27014

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

francois-guerin-ledger · 2026-02-26T21:02:24Z

libs/coin-modules/coin-evm/src/network/node/ledger.test.ts

        );
      });

-      it("should return 0 for invalid transaction", async () => {


Already covered by gives 0 additional fees if the transaction is not serializable

francois-guerin-ledger · 2026-02-26T21:02:35Z

libs/coin-modules/coin-evm/src/network/node/ledger.test.ts

        );
      });

-      it("should return 0 for invalid transaction", async () => {


Already covered by gives 0 additional fees if the transaction is not serializable

francois-guerin-ledger · 2026-02-26T21:06:26Z

libs/coin-modules/coin-evm/src/network/node/types.ts

+  getOptimismAdditionalFees: (currency: CryptoCurrency, transaction: string) => Promise<BigNumber>;
+  getScrollAdditionalFees: (currency: CryptoCurrency, transaction: string) => Promise<BigNumber>;


transaction is only passed as string in production code

Copilot

Pull request overview

Refactors the coin-evm module by removing unused/publicly unreferenced code paths and updating Layer2 additional-fee computation to work with serialized transactions, with corresponding test and docs cleanup.

Changes:

Remove dead exports/types/helpers (ERC20 tuple type, ethers adapter, transaction serialization/data helpers, various logic helpers/errors).
Update Optimism/Scroll additional-fee APIs to accept a serialized transaction string and adjust tests accordingly.
Prune/update documentation to match the reduced public surface.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
libs/coin-modules/coin-evm/src/types/ledger.ts	Removes unused ledger explorer block type.
libs/coin-modules/coin-evm/src/types/index.ts	Stops re-exporting the `erc20` types module.
libs/coin-modules/coin-evm/src/types/erc20.ts	Deletes the legacy `ERC20Token` tuple type.
libs/coin-modules/coin-evm/src/transaction.ts	Removes smart-contract calldata + tx serialization helpers.
libs/coin-modules/coin-evm/src/transaction.test.ts	Drops tests tied to removed transaction helpers/adapters.
libs/coin-modules/coin-evm/src/network/node/types.ts	Narrows additional-fee APIs to accept serialized tx strings only.
libs/coin-modules/coin-evm/src/network/node/rpc.test.ts	Updates tests to pass serialized ethers transactions.
libs/coin-modules/coin-evm/src/network/node/rpc.common.ts	Removes internal serialization path; uses serialized tx string directly.
libs/coin-modules/coin-evm/src/network/node/ledger.ts	Removes internal serialization path; uses serialized tx string directly.
libs/coin-modules/coin-evm/src/network/node/ledger.test.ts	Updates tests to pass serialized ethers transactions.
libs/coin-modules/coin-evm/src/logic/estimateFees.test.ts	Renames a test description to “serializable”.
libs/coin-modules/coin-evm/src/logic.ts	Removes several unused helpers and narrows additional-fee helper signature.
libs/coin-modules/coin-evm/src/logic.test.ts	Removes tests for deleted helpers.
libs/coin-modules/coin-evm/src/errors.ts	Removes unused custom error classes.
libs/coin-modules/coin-evm/src/adapters/index.ts	Stops exporting the ethers adapter module.
libs/coin-modules/coin-evm/src/adapters/ethers.ts	Deletes the ethers transaction adapter.
libs/coin-modules/coin-evm/src/adapters/ethers.test.ts	Deletes tests for the removed ethers adapter.
libs/coin-modules/coin-evm/docs/transaction.md	Removes docs for deleted transaction helpers.
libs/coin-modules/coin-evm/docs/logic.md	Removes docs for deleted logic helpers; minor formatting alignment.
libs/coin-modules/coin-evm/docs/adapters.md	Removes docs for deleted ethers adapter.
.changeset/lazy-mayflies-itch.md	Adds a patch changeset for the refactor.

Comments suppressed due to low confidence (1)

libs/coin-modules/coin-evm/src/transaction.ts:206

This module removes previously exported helpers (getTransactionData, getSerializedTransaction). Even if currently unused in this repo, they were part of the public @ledgerhq/coin-evm/transaction API, so this is a breaking change for any downstream consumer. Consider keeping deprecated wrappers for one release (or ensure the changeset/semver bump matches a breaking change).

  return txRaw as EvmTransactionRaw;
};

/**
 * Returns a transaction with the correct type and entries depending
 * on the network compatiblity.
 */
export const getTypedTransaction = (
  _transaction: EvmTransaction,

libs/coin-modules/coin-evm/src/network/node/ledger.ts

.changeset/lazy-mayflies-itch.md

libs/coin-modules/coin-evm/src/types/index.ts

libs/coin-modules/coin-evm/src/adapters/index.ts

github-actions · 2026-02-27T08:42:59Z

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

Select "Run workflow"
Branch: refactor/no-issues-remove-dead-code-evm
Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

Select "Run workflow"
Branch: refactor/no-issues-remove-dead-code-evm
Device: nanoX

Affected coins modules: evm

qperrot

Do not forget to run e2e tests

francois-guerin-ledger · 2026-03-02T08:42:52Z

~~E2E iOS: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/326fe980-2c3a-4598-bfd2-aaa385cf6008/~~
~~E2E Android: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/344723ec-2e69-4fc1-9c14-ed15f20672d9/~~
Mobile E2E were not accurate, need to rebase to develop.
E2E desktop: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/96d629cc-a3b4-4b5e-9801-4144bd4594ed/

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

libs/coin-modules/coin-evm/src/network/node/rpc.common.ts

libs/coin-modules/coin-evm/src/network/node/ledger.ts

francois-guerin-ledger · 2026-03-02T16:52:49Z

E2E iOS: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/8caa8dd7-de33-4be5-a263-6f03fe89215b/
E2E Android: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/6dbe71e5-417d-424f-858e-66d380292256/

francois-guerin-ledger · 2026-03-03T07:47:38Z

E2E Android: https://github.com/LedgerHQ/ledger-live/actions/runs/22613373260
E2E iOS: https://github.com/LedgerHQ/ledger-live/actions/runs/22613373260

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-03T11:00:34Z

libs/coin-modules/coin-evm/src/network/node/rpc.test.ts

    it("should return 0 if the currency isn't optimism", async () => {
      expect(


This test is in the getScrollAdditionalFees suite but the description says "currency isn't optimism". Please rename it to refer to Scroll to keep intent clear and avoid confusion when scanning test output.

sonarqubecloud · 2026-03-03T11:41:03Z

Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-actions bot assigned francois-guerin-ledger Feb 26, 2026

live-github-bot bot added the coin-modules label Feb 26, 2026

francois-guerin-ledger force-pushed the refactor/no-issues-remove-dead-code-evm branch 3 times, most recently from bea316f to 0b38978 Compare February 26, 2026 16:49

francois-guerin-ledger commented Feb 26, 2026

View reviewed changes

francois-guerin-ledger marked this pull request as ready for review February 26, 2026 21:08

francois-guerin-ledger requested a review from a team as a code owner February 26, 2026 21:08

Copilot AI review requested due to automatic review settings February 26, 2026 21:08

Copilot started reviewing on behalf of francois-guerin-ledger February 26, 2026 21:09 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

francois-guerin-ledger force-pushed the refactor/no-issues-remove-dead-code-evm branch from 0b38978 to fa38757 Compare February 27, 2026 08:40

qperrot approved these changes Mar 2, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 2, 2026 13:45

francois-guerin-ledger force-pushed the refactor/no-issues-remove-dead-code-evm branch from fa38757 to a74569e Compare March 2, 2026 13:45

Copilot started reviewing on behalf of francois-guerin-ledger March 2, 2026 13:45 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

libs/coin-modules/coin-evm/src/network/node/rpc.common.ts Show resolved Hide resolved

libs/coin-modules/coin-evm/src/network/node/ledger.ts Show resolved Hide resolved

libs/coin-modules/coin-evm/src/network/node/ledger.ts Show resolved Hide resolved

francois-guerin-ledger force-pushed the refactor/no-issues-remove-dead-code-evm branch from a74569e to d2146bc Compare March 3, 2026 10:04

Copilot AI review requested due to automatic review settings March 3, 2026 10:55

francois-guerin-ledger force-pushed the refactor/no-issues-remove-dead-code-evm branch from d2146bc to 6a992d6 Compare March 3, 2026 10:55

Copilot started reviewing on behalf of francois-guerin-ledger March 3, 2026 10:55 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

refactor(coin-evm): remove some dead code

2e1d372

francois-guerin-ledger force-pushed the refactor/no-issues-remove-dead-code-evm branch from 6a992d6 to 2e1d372 Compare March 3, 2026 11:18

		getOptimismAdditionalFees: (currency: CryptoCurrency, transaction: string) => Promise<BigNumber>;
		getScrollAdditionalFees: (currency: CryptoCurrency, transaction: string) => Promise<BigNumber>;

		it("should return 0 if the currency isn't optimism", async () => {
		expect(

Conversation

francois-guerin-ledger commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

Uh oh!

francois-guerin-ledger Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

francois-guerin-ledger Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

francois-guerin-ledger Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ E2E tests are required

🖥️ Desktop

📱 Mobile

Uh oh!

qperrot left a comment

Choose a reason for hiding this comment

Uh oh!

francois-guerin-ledger commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

francois-guerin-ledger commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francois-guerin-ledger commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 3, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

francois-guerin-ledger commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 27, 2026 •

edited

Loading

francois-guerin-ledger commented Mar 2, 2026 •

edited

Loading

francois-guerin-ledger commented Mar 2, 2026 •

edited

Loading